fix: embed prompts as strings for Bun bundler compatibility #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original approach using __dirname + readFileSync doesn't work correctly when the package is bundled by Bun, as __dirname resolves to incorrect paths at runtime. This causes 'Cannot find module' and 'ENOENT' errors. This fix embeds all prompt content as string constants, eliminating the need for filesystem access at runtime and ensuring compatibility with Bun's bundler as well as other ESM bundlers.
Collaborator
|
Is this necessary? I don't think the bundler is even used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.txtfiles at runtime__dirnameresolves incorrectlyProblem
When the package is bundled by Bun, the original approach using
__dirname + readFileSyncfails because__dirnameresolves to incorrect paths at runtime. This causes errors like:Root Cause
Bun's bundler doesn't preserve
__dirnamesemantics correctly when files are bundled. The.txtfiles exist in the package, but the runtime path resolution fails.Solution
Embed all prompt content directly as string constants in
lib/prompts/index.ts. This:loadPrompt()APITesting
Tested locally by patching the installed package in
~/.cache/opencode/node_modules/@tarquinen/opencode-dcp/- the errors are resolved and the package works correctly.Changes
lib/prompts/index.ts: ReplacedreadFileSyncapproach with embedded string constants